Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added info varinat for toast #55

Merged
merged 1 commit into from
May 4, 2024
Merged

added info varinat for toast #55

merged 1 commit into from
May 4, 2024

Conversation

Swathi-eGov
Copy link
Contributor

No description provided.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 4, 2024 •
edited
Loading

Walkthrough

The recent updates focus on enhancing the styling and functionality of toast notifications across the React project. Key changes include version updates in CSS links, new style definitions for info alerts, and expanded toast functionalities in components to handle various toast types with customization options like transition times.

Changes

Files Changes
.../index.css, .../public/index.html Updated version from 1.8.2-coreui.10 to 1.8.2-coreui.11. Adjusted styles for specific toast classes. Updated CSS link in HTML.
.../components/toastV2.scss Added style block for digit-info.
.../src/atoms/Toast.js, .../stories/Toast.stories.js Enhanced toast handling with info prop, added new toast types and transition time settings.

🐰✨
A hop, a skip, a code deploy,
Toasts pop up, oh what a joy!
Colors shift, and links do too,
With each update, our app feels new!
Cheers to changes, big and small,
CodeRabbit watches over all! 🌟

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 8175c23 and ff41d32.
Files ignored due to path filters (9)
  • react/css/package.json is excluded by !**/*.json
  • react/example/package.json is excluded by !**/*.json
  • react/modules/Project/package.json is excluded by !**/*.json
  • react/modules/core/package.json is excluded by !**/*.json
  • react/modules/sample/package.json is excluded by !**/*.json
  • react/package.json is excluded by !**/*.json
  • react/ui-components/package.json is excluded by !**/*.json
  • react/ui-components/yarn-error.log is excluded by !**/*.log, !**/*.log
  • react/yarn-error.log is excluded by !**/*.log, !**/*.log
Files selected for processing (7)
  • react/css/README.md (1 hunks)
  • react/css/example/index.css (3 hunks)
  • react/css/src/digitv2/components/toastV2.scss (1 hunks)
  • react/example/public/index.html (1 hunks)
  • react/ui-components/README.md (1 hunks)
  • react/ui-components/src/atoms/Toast.js (3 hunks)
  • react/ui-components/src/hoc/stories/Toast.stories.js (1 hunks)
Files skipped from review due to trivial changes (2)
  • react/css/example/index.css
  • react/css/src/digitv2/components/toastV2.scss
Additional Context Used
LanguageTool (18)
react/css/README.md (11)

Near line 3: This sentence does not start with an uppercase letter.
Context: # digit-ui-css ## Install ```bash npm install --save...

Near line 20: Possible missing comma found.
Context: ...it UI's ``` ## Usage After adding the dependency make sure you have this dependency in ...

Near line 80: Possible spelling mistake found.
Context: ....5.23 base version ``` # Contributors [jagankumar-egov] [nipunarora-eGov] [Tulika-eGov] [Ramkr...

Near line 80: Possible spelling mistake found.
Context: ... ``` # Contributors [jagankumar-egov] [nipunarora-eGov] [Tulika-eGov] [Ramkrishna-egov] [nabee...

Near line 80: Possible spelling mistake found.
Context: ...s [jagankumar-egov] [nipunarora-eGov] [Tulika-eGov] [Ramkrishna-egov] [nabeelmd-eGov] [ani...

Near line 80: Possible spelling mistake found.
Context: ...-egov] [nipunarora-eGov] [Tulika-eGov] [Ramkrishna-egov] [nabeelmd-eGov] [anil-egov] [vamshikri...

Near line 80: Possible spelling mistake found.
Context: ...-eGov] [Tulika-eGov] [Ramkrishna-egov] [nabeelmd-eGov] [anil-egov] [vamshikrishnakole-wtt-ego...

Near line 80: Possible spelling mistake found.
Context: ...Gov] [Ramkrishna-egov] [nabeelmd-eGov] [anil-egov] [vamshikrishnakole-wtt-egov] ## Publ...

Near line 80: Possible spelling mistake found.
Context: ...shna-egov] [nabeelmd-eGov] [anil-egov] [vamshikrishnakole-wtt-egov] ## Published from DIGIT Core Digit ...

Near line 82: This phrase is duplicated. You should probably use “DIGIT Core” only once.
Context: ...ishnakole-wtt-egov] ## Published from DIGIT Core Digit Core Repo (https://github.com/egovernments/D...

Near line 87: Possible spelling mistake found.
Context: ...tree/digit-ui-core) ## License MIT © jagankumar-egov

react/ui-components/README.md (7)

Near line 2: This sentence does not start with an uppercase letter.
Context: # digit-ui-components ## Install ```bash npm install --save...

Near line 83: Possible spelling mistake found.
Context: ...m/tree/digit-ui-core) # Contributors [nabeelmd-egov] [anilsingha-eGov] [nipunarora-eGov] [s...

Near line 83: Possible spelling mistake found.
Context: ...core) # Contributors [nabeelmd-egov] [anilsingha-eGov] [nipunarora-eGov] [swathi-egov] [jagan...

Near line 83: Possible spelling mistake found.
Context: ...ors [nabeelmd-egov] [anilsingha-eGov] [nipunarora-eGov] [swathi-egov] [jagankumar-egov] # Ref...

Near line 83: Possible spelling mistake found.
Context: ...v] [anilsingha-eGov] [nipunarora-eGov] [swathi-egov] [jagankumar-egov] # Reference Home P...

Near line 83: Possible spelling mistake found.
Context: ...-eGov] [nipunarora-eGov] [swathi-egov] [jagankumar-egov] # Reference Home Page (https://unifi...

Near line 91: Possible spelling mistake found.
Context: ...git.org/storybook/) ## License MIT © jagankumar-egov !...

Additional comments not posted (6)
react/example/public/index.html (1)

12-12: Updated CSS link to the new version as expected.

react/ui-components/README.md (1)

61-61: Changelog correctly updated to reflect the addition of the "info" variant for toast.

react/ui-components/src/hoc/stories/Toast.stories.js (2)

46-51: Added InfoToast story for the new "info" variant as expected.

76-82: Added InfoToastWithTransitionTime story for testing the "info" variant with custom transition times.

react/css/README.md (1)

45-45: Changelog correctly updated to reflect the addition of the "info" variant for toast in the CSS package.

react/ui-components/src/atoms/Toast.js (1)

74-91: Added handling for the info prop to render an info toast with unique styling and content as expected.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 4, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Out of diff range and nitpick comments (1)
react/ui-components/src/atoms/Toast.js (1)

1-1: Imported Fragment but it is not used in the file. Consider removing it if it's not needed.

@jagankumar-egov jagankumar-egov merged commit 56b4181 into develop May 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagankumar-egov jagankumar-egov jagankumar-egov approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swathi-eGov @jagankumar-egov