updated checkbox component - removed customlabelmarkup

[Swathi-eGov]

No description provided.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)

• react/example/package.json is excluded by !**/*.json
• react/package.json is excluded by !**/*.json

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request involves removing the customLabelMarkup prop from the CheckBox component across multiple files in the React UI components. This change simplifies the label rendering logic by removing a specific conditional rendering approach for checkbox labels. The modifications are consistent across different components like CheckBox, TableCell, FieldComposer, FieldV1, and Fields, indicating a systematic removal of this prop throughout the application.

Changes

File	Change Summary
react/ui-components/src/atoms/CheckBox.js	Removed customLabelMarkup prop and simplified label rendering logic
react/ui-components/src/atoms/TableCell.js	Removed customLabelMarkup prop from CheckBox component rendering
react/ui-components/src/hoc/FieldComposer.js	Removed customLabelMarkup prop from checkbox rendering, simplified method signature
react/ui-components/src/hoc/FieldV1.js	Removed customLabelMarkup prop from CheckBox component
react/ui-components/src/hoc/Fields.js	Removed customLabelMarkup prop from checkbox case in switch statement

Poem

🐰 A Checkbox's Label, Once Complex
Custom markup, now we've stripped
Simplicity reigns, no extra flips
Just pure text, clean and crisp
A rabbit's code, now neatly clipped! 🏷️

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

react/ui-components/src/atoms/CheckBox.js (2)

Line range hint 9-96: Consider accessibility and testing improvements.

While the changes look good, here are some suggestions to enhance the component:

1. Add aria-label for better screen reader support
2. Consider adding a data-testid prop for easier testing
3. Add JSDoc comments for the remaining props

Here's how you could implement these improvements:

 const CheckBox = ({
   onChange,
   label,
   value,
   disabled,
   ref,
   checked,
   inputRef,
   pageType,
   style,
   index,
   isLabelFirst,
   hideLabel,
   isIntermediate,
+  'data-testid': dataTestId,
   ...props
 }) => {
   // ...
         <input
           type="checkbox"
           className={`input ${userType === "employee" ? "input-emp" : ""} ${props?.inputClassName} `}
           onChange={onChange}
           value={value || label}
+          aria-label={sentenceCaseLabel}
+          data-testid={dataTestId}
           {...props}
           ref={inputRef}
           disabled={disabled}
           checked={checked}
         />

---

Line range hint 75-96: Document remaining props in PropTypes.

Several props are used but not documented in PropTypes:

• disabled
• checked
• isLabelFirst
• style
• pageType

Add these to PropTypes with appropriate JSDoc comments:

 CheckBox.propTypes = {
   /**
    * CheckBox content
    */
   label: PropTypes.string.isRequired,
   /**
    * onChange func
    */
   onChange: PropTypes.func,
   /**
    * input ref
    */
   ref: PropTypes.func,
   userType: PropTypes.string,
   hideLabel:PropTypes.bool,
   isIntermediate: PropTypes.bool,
+  /**
+   * Disables the checkbox
+   */
+  disabled: PropTypes.bool,
+  /**
+   * Controls the checked state
+   */
+  checked: PropTypes.bool,
+  /**
+   * Controls label position
+   */
+  isLabelFirst: PropTypes.bool,
+  /**
+   * Additional styles
+   */
+  style: PropTypes.object,
+  /**
+   * Page type for styling
+   */
+  pageType: PropTypes.string,
 };

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5dc7a8 and 9546877.

⛔ Files ignored due to path filters (6)

• react/example/package.json is excluded by !**/*.json
• react/modules/Project/package.json is excluded by !**/*.json
• react/modules/core/package.json is excluded by !**/*.json
• react/modules/sample/package.json is excluded by !**/*.json
• react/package.json is excluded by !**/*.json
• react/ui-components/package.json is excluded by !**/*.json

📒 Files selected for processing (5)

• react/ui-components/src/atoms/CheckBox.js (2 hunks)
• react/ui-components/src/atoms/TableCell.js (0 hunks)
• react/ui-components/src/hoc/FieldComposer.js (0 hunks)
• react/ui-components/src/hoc/FieldV1.js (0 hunks)
• react/ui-components/src/hoc/Fields.js (0 hunks)

💤 Files with no reviewable changes (4)

• react/ui-components/src/hoc/FieldV1.js
• react/ui-components/src/atoms/TableCell.js
• react/ui-components/src/hoc/Fields.js
• react/ui-components/src/hoc/FieldComposer.js

🔇 Additional comments (1)

react/ui-components/src/atoms/CheckBox.js (1)

42-42: LGTM! Label rendering simplified.

The removal of customLabelMarkup in favor of direct sentenceCaseLabel rendering improves code maintainability while maintaining consistent label display.

Also applies to: 70-70