-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding localisation for info #132
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
react/ui-components/src/hoc/FieldV1.js (1)
383-383
: LGTM! Consider extracting the translation key.The change correctly implements localization for the
infoMessage
, which aligns with the PR objective. Good job on improving the internationalization support of the component.As a minor suggestion, consider extracting the translation key to a constant or using a more specific key if it's not already. This can help with maintaining translations across the application.
For example:
const INFO_MESSAGE_KEY = 'field.infoMessage'; // ... <span class="infotext">{t(INFO_MESSAGE_KEY)}</span>This approach can make it easier to manage and update translations in the future.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
🔇 Files ignored due to path filters (1)
react/ui-components/package.json
is excluded by!**/*.json
📒 Files selected for processing (1)
- react/ui-components/src/hoc/FieldV1.js (1 hunks)
7df0f74
to
fea05ff
Compare
No description provided.