Add RequiresUnreferencedCode to Delegate constructors

Contributes to dotnet#45623
eerhardt · Dec 14, 2020 · de3a322 · de3a322
1 parent 296aaf8
commit de3a322
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 12 deletions.
diff --git a/src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs b/src/coreclr/System.Private.CoreLib/src/System/Delegate.CoreCLR.cs
@@ -33,6 +33,7 @@ public abstract partial class Delegate : ICloneable, ISerializable
 
         // This constructor is called from the class generated by the
         //  compiler generated code
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected Delegate(object target, string method)
         {
             if (target == null)
@@ -56,6 +57,7 @@ protected Delegate(object target, string method)
         // This constructor is called from a class to generate a
         // delegate based upon a static method name and the Type object
         // for the class defining the method.
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected Delegate(Type target, string method)
         {
             if (target == null)

diff --git a/src/coreclr/System.Private.CoreLib/src/System/MulticastDelegate.cs b/src/coreclr/System.Private.CoreLib/src/System/MulticastDelegate.cs
@@ -25,13 +25,15 @@ public abstract class MulticastDelegate : Delegate
         // This constructor is called from the class generated by the
         //    compiler generated code (This must match the constructor
         //    in Delegate
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected MulticastDelegate(object target, string method) : base(target, method)
         {
         }
 
         // This constructor is called from a class to generate a
         // delegate based upon a static method name and the Type object
         // for the class defining the method.
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected MulticastDelegate(Type target, string method) : base(target, method)
         {
         }

diff --git a/src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Suppressions.Shared.xml b/src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Suppressions.Shared.xml
@@ -19,18 +19,6 @@
       <property name="Scope">member</property>
       <property name="Target">M:Internal.Runtime.InteropServices.IsolatedComponentLoadContext.Load(System.Reflection.AssemblyName)</property>
     </attribute>
-    <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
-      <argument>ILLink</argument>
-      <argument>IL2026</argument>
-      <property name="Scope">member</property>
-      <property name="Target">M:System.Delegate.#ctor(System.Object,System.String)</property>
-    </attribute>
-    <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
-      <argument>ILLink</argument>
-      <argument>IL2026</argument>
-      <property name="Scope">member</property>
-      <property name="Target">M:System.Delegate.#ctor(System.Type,System.String)</property>
-    </attribute>
     <attribute fullname="System.Diagnostics.CodeAnalysis.UnconditionalSuppressMessageAttribute">
       <argument>ILLink</argument>
       <argument>IL2026</argument>

diff --git a/src/libraries/System.Runtime/ref/System.Runtime.cs b/src/libraries/System.Runtime/ref/System.Runtime.cs
@@ -1691,7 +1691,9 @@ void System.Runtime.Serialization.ISerializable.GetObjectData(System.Runtime.Ser
     }
     public abstract partial class Delegate : System.ICloneable, System.Runtime.Serialization.ISerializable
     {
+        [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("The target method might be removed")]
         protected Delegate(object target, string method) { }
+        [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("The target method might be removed")]
         protected Delegate(System.Type target, string method) { }
         public System.Reflection.MethodInfo Method { get { throw null; } }
         public object? Target { get { throw null; } }
@@ -2933,7 +2935,9 @@ public MTAThreadAttribute() { }
     }
     public abstract partial class MulticastDelegate : System.Delegate
     {
+        [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("The target method might be removed")]
         protected MulticastDelegate(object target, string method) : base (default(object), default(string)) { }
+        [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCodeAttribute("The target method might be removed")]
         protected MulticastDelegate(System.Type target, string method) : base (default(object), default(string)) { }
         protected sealed override System.Delegate CombineImpl(System.Delegate? follow) { throw null; }
         public sealed override bool Equals(object? obj) { throw null; }

diff --git a/src/mono/netcore/System.Private.CoreLib/src/System/Delegate.Mono.cs b/src/mono/netcore/System.Private.CoreLib/src/System/Delegate.Mono.cs
@@ -71,6 +71,7 @@ public partial class Delegate
         private bool method_is_virtual;
         #endregion
 
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected Delegate(object target, string method)
         {
             if (target is null)
@@ -86,6 +87,7 @@ protected Delegate(object target, string method)
             };
         }
 
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected Delegate(Type target, string method)
         {
             if (target is null)

diff --git a/src/mono/netcore/System.Private.CoreLib/src/System/MulticastDelegate.cs b/src/mono/netcore/System.Private.CoreLib/src/System/MulticastDelegate.cs
@@ -12,11 +12,13 @@ public abstract class MulticastDelegate : Delegate
     {
         private Delegate[]? delegates;
 
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected MulticastDelegate(object target, string method)
             : base(target, method)
         {
         }
 
+        [RequiresUnreferencedCode("The target method might be removed")]
         protected MulticastDelegate(Type target, string method)
             : base(target, method)
         {