Escape $ in patterns #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$` is a valid character in an identifier (`Character.isJavaIdentifierPart`) and thus it is (correctly) accepted by jarjar in rule patterns, but it is not escaped when building the regex (which is not necessary for other identifier characters). This makes it impossible to match inner classes (which always contain a `$`) and other synthetic classes directly (which is necessary to rename classes instead of simply moving them to other packages). Escaping it as `\$` makes these matches work correctly.
|
can we add a test for this case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$is a valid character in an identifier (Character.isJavaIdentifierPart) and thus it is (correctly) accepted by jarjar in rule patterns, but it is not escaped when building the regex (which is not necessary for other identifier characters). This makes it impossible to match inner classes (which always contain a$) and other synthetic classes directly (which is necessary to rename classes instead of simply moving them to other packages). Escaping it as\$makes these matches work correctly.