Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-145 - Listed security is improperly inferred to be a listing #1245

Merged
merged 5 commits into from
Dec 16, 2020

Conversation

ElisaKendall
Copy link
Contributor

Signed-off-by: Elisa Kendall ekendall@thematix.com

Description

Eliminated confusion between listed security and listing which caused reasoning errors, corrected ticker symbol as identifying a listed security rather than listing, streamlined hierarchy for registered securities, and eliminated ambiguity in definitions

Fixes: #1244 / SEC-145

Checklist:

  • I'm familiar with the FIBO developer quide. My contribution meets all the requirements described there.
  • My contribution follows the principles of best practices for FIBO.
  • My changes have been reconciled with latest master and no merge conflicts remain.
  • This PR is related to exactly one issue. The issue is referenced by using a GitHub keyword such as "fixes", "closes", or "resolves".
  • Hygiene tests have been applied by a PR with "(WIP)" in title.
  • The issue has been tested locally using a reasoner (for ontology changes).

…isting which caused reasoning errors, corrected ticker symbol as identifying a listed security rather than listing, streamlined hierarchy for registered securities, and eliminated ambiguity in definitions

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@ElisaKendall ElisaKendall added bug SEC FIBO Securities labels Dec 11, 2020
@ElisaKendall ElisaKendall self-assigned this Dec 11, 2020
jfgemski
jfgemski previously approved these changes Dec 11, 2020
Copy link
Contributor

@rivettp rivettp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments on the issue

Copy link
Contributor

@rivettp rivettp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made more specific comments.

</owl:Restriction>
</rdfs:subClassOf>
<rdfs:label>security registry entry</rdfs:label>
<skos:definition>record for a listed security in a securities repository</skos:definition>
<skos:definition>record for a security in a securities repository</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure that "repository" is the right word here - it does not store the securities in any way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to registry

@@ -433,7 +398,7 @@
<rdfs:subClassOf>
<owl:Restriction>
<owl:onProperty rdf:resource="&lcc-lr;identifies"/>
<owl:someValuesFrom rdf:resource="&fibo-sec-sec-lst;Listing"/>
<owl:someValuesFrom rdf:resource="&fibo-sec-sec-lst;ListedSecurity"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No is's more specific than this: it represents the offer from a specific Exchange: the actual Security is referenced only indirectly. ListedSecurity WAS the issued share (in the case of equities) which is available through multiple exchanges, and it may have a different ticker on each. I see you've changed the definition of ListedSecurity to be for a single exchange which could have a broader impact

@@ -147,7 +149,7 @@
</owl:Restriction>
</rdfs:subClassOf>
<rdfs:label>listed security</rdfs:label>
<skos:definition>registered security listed on one or more exchanges</skos:definition>
<skos:definition>registered security listed on some exchange</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a minor wording change but has a major impact. It in effect replaces what was Listing and so needs several of the latter's properties moved over e.g. a link to the IssuedSecurity that is listed, and the currency

<rdfs:label xml:lang="en">listing</rdfs:label>
<skos:definition>registry entry for a security that provides information regarding the eligibility for making that security available for trading</skos:definition>
<skos:definition>registry entry for a security that is managed by an exchange and that provides registration information regarding the eligibility for making that security available for trading</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything about "eligibility"

<rdfs:label xml:lang="en">listing</rdfs:label>
<skos:definition>registry entry for a security that provides information regarding the eligibility for making that security available for trading</skos:definition>
<skos:definition>registry entry for a security that is managed by an exchange and that provides registration information regarding the eligibility for making that security available for trading</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be modeling pure data artifacts such as "registry entry" which will be specific to each Exchange and probably proprietary. All these properties are actually applicable to the Offering which was Listing and is now ListedSecurity. In other words I don't think we need separate classes.

@@ -278,7 +268,7 @@
<rdfs:label>has home exchange</rdfs:label>
<rdfs:range rdf:resource="&fibo-fbc-fct-mkt;Exchange"/>
<skos:definition>indicates the current exchange that is considered the primary trading venue for a security</skos:definition>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what does it mean to be the "primary trading venue"?

@@ -278,7 +268,7 @@
<rdfs:label>has home exchange</rdfs:label>
<rdfs:range rdf:resource="&fibo-fbc-fct-mkt;Exchange"/>
<skos:definition>indicates the current exchange that is considered the primary trading venue for a security</skos:definition>
<fibo-fnd-utl-av:explanatoryNote>A security may have been originally listed on the Frankfort exchange, but its current home is the London Stock Exchange, for example.</fibo-fnd-utl-av:explanatoryNote>
<fibo-fnd-utl-av:explanatoryNote>A security may have been originally listed on the Frankfurt exchange, but its current home is the London Stock Exchange, for example.</fibo-fnd-utl-av:explanatoryNote>
<fibo-fnd-utl-av:synonym>has primary trading market</fibo-fnd-utl-av:synonym>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also "has primary trading venue"?

@trypuz trypuz added this to the 2020 Q4 FIBO Release milestone Dec 12, 2020
… definitions

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
… to say 'at least one' rather than 'one or more' per FCT discussion

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
…ht identify a listing rather than only a financial instrument, eliminated the notion of a preferred identifier for an exchange as unnecessary, per feedback

Signed-off-by: Elisa Kendall <ekendall@thematix.com>
@rivettp
Copy link
Contributor

rivettp commented Dec 15, 2020

See example file I just sent you to prove my point

@trypuz trypuz merged commit 51f1f9f into edmcouncil:master Dec 16, 2020
@ElisaKendall ElisaKendall deleted the SEC-145 branch December 16, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug SEC FIBO Securities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listed security is improperly inferred to be a listing
5 participants