-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some refactoring after review #1
Conversation
Don't encourage side-effects via passed values
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
==========================================
+ Coverage 86.91% 87.61% +0.69%
==========================================
Files 3 3
Lines 107 113 +6
==========================================
+ Hits 93 99 +6
+ Misses 8 7 -1
- Partials 6 7 +1
Continue to review full report at Codecov.
|
MapItem's can only occur in MapSlice's, but the current process() call in traverse() assumes that it can be the other way around.
It seems that Codecov check results are now being affected by an issue similar to kata-containers/tests#508. Judging by the fact that this still isn't fixed since 2018 at the Codecov's side, I've disabled the check in 02bac8b. Perhaps one day we should try Coveralls to see if it's any better. |
Thanks for the submission, the changes are dope (especially the function closure) 👍 |
Please check commit by commit messages and changes. Please let me know if you have any concerns.