Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some refactoring after review #1

Merged
merged 7 commits into from
May 26, 2020

Conversation

fkorotkov
Copy link
Contributor

Please check commit by commit messages and changes. Please let me know if you have any concerns.

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #1 into master will increase coverage by 0.69%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   86.91%   87.61%   +0.69%     
==========================================
  Files           3        3              
  Lines         107      113       +6     
==========================================
+ Hits           93       99       +6     
+ Misses          8        7       -1     
- Partials        6        7       +1     
Impacted Files Coverage Δ
preprocessor/expander.go 89.47% <80.00%> (+3.03%) ⬆️
preprocessor/preprocessor.go 87.75% <90.00%> (-2.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e179e45...02bac8b. Read the comment docs.

MapItem's can only occur in MapSlice's, but the current process()
call in traverse() assumes that it can be the other way around.
@edigaryev
Copy link
Owner

I've fixed a minor linter error to let the pipeline go (46a06ad) and found some useless code path from the original implementation while investigating the coverage drop (aaeffba). Hopefully you don't mind :)

@edigaryev
Copy link
Owner

It seems that Codecov check results are now being affected by an issue similar to kata-containers/tests#508.

Judging by the fact that this still isn't fixed since 2018 at the Codecov's side, I've disabled the check in 02bac8b.

Perhaps one day we should try Coveralls to see if it's any better.

@edigaryev edigaryev merged commit 902a5a6 into edigaryev:master May 26, 2020
@edigaryev
Copy link
Owner

Thanks for the submission, the changes are dope (especially the function closure) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants