Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copy fails with umbrella mix test stale (make Mimic.copy idempotent) #47

Merged

Conversation

dylan-chong
Copy link
Contributor

@dylan-chong dylan-chong commented Jul 27, 2022

Fixes #44

Have tested in an umbrella app and works great!

@dylan-chong dylan-chong marked this pull request as draft July 27, 2022 11:07
@dylan-chong dylan-chong force-pushed the fix/copy-fails-with-umbrella-mix-test-stale branch from 6c93cb0 to 436f73e Compare July 27, 2022 11:12
@dylan-chong dylan-chong force-pushed the fix/copy-fails-with-umbrella-mix-test-stale branch from 436f73e to f9e17cd Compare July 27, 2022 11:17
@dylan-chong dylan-chong marked this pull request as ready for review July 27, 2022 11:21
Copy link
Owner

@edgurgel edgurgel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you! 🎉

@edgurgel edgurgel merged commit 43dc36b into edgurgel:main Jul 28, 2022
@dylan-chong dylan-chong deleted the fix/copy-fails-with-umbrella-mix-test-stale branch July 28, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mimic.copy could be idempotent
2 participants