FIX: Memory leak: HTTPoison.Base.transformer #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `Process.monitor` had been called in every recursion for the target even though we only need to call it only once.
Zarathustra2
changed the title
|
Thanks! Nice catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
Process.monitorhad been called in every recursionfor the target even though we only need to call it only once.
I observed that on production when using httpoison to consume server sent events. Noticed in the observer_cli:
I am currently using the PR code in production and it fixed the issue. Now also the blacked out processes to which I stream the server sent events ( so they are the target which has been monitored via Process.monitor(target) in the tranformer ) have a memory footprint of 8MB.