Build towards easier WCAG Compliance #109
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiewebb
reviewed
Jan 6, 2025
| @@ -7,6 +7,6 @@ <h3 class="mb-0">{{ .Params.pubtype }} - <a href="{{ .Permalink }}">{{ .Params.t | |||
| </div> | |||
| <div class="resume-date text-md-right"> | |||
| <span class="text-primary">{{ .Params.date | dateFormat "January 2006" }}</span> | |||
| <img src="{{ .Params.image }}" style="max-width:250px;padding:5px;"/> | |||
| <img src="{{ .Params.image }}" {{if .Params.imageDescription }}alt="{{ .Params.imageDescription }}"{{ else }}alt=""{{ end }} style="max-width:250px;padding:5px;"/> | |||
There was a problem hiding this comment.
why is an empty alt preffered over just omitting it?
There was a problem hiding this comment.
Empty Alt can be used to indicate an image is decorative, see https://www.w3.org/WAI/tutorials/images/decorative/
|
Appreciate this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I really like this theme, but I need better WCAG compliance than it offers by default.
I'm starting to edit partials to help make the template more compliant. I will mark it as ready, but I would appreciate your feedback.