fix/self_reference_validation #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes two bugs that prevented self-references (such as `objectiveAssessment.parentObjectiveAssessmentReference` from validating correctly: 1. reference fields were resolved to an endpoint by simply removing the `Reference` suffix, which obviously doesn't work for `parentObjectiveReference`s 2. cache keys (which are used to efficiently look up whether a referenced payload has been found) were sensitive to dict key ordering This PR fixes both bugs and ensures that self-references validate correctly.
ejoranlienea
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs that prevented self-references (such as
objectiveAssessment.parentObjectiveAssessmentReference) from validating correctly:Referencesuffix, which obviously doesn't work forparentObjectiveReferencesThis PR fixes both bugs and ensures that self-references validate correctly.
Additionally, the PR fixes several stray references to
line_counterwhich was changed in this PR toline_number(I ran into errors aboutline_counterbeing undefined while testing this PR).