Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support different level of authentication through authenticationLevel config parameter #21

Merged
merged 6 commits into from
Oct 13, 2021
Merged

Support different level of authentication through authenticationLevel config parameter #21

merged 6 commits into from
Oct 13, 2021

Conversation

drupol
Copy link
Member

@drupol drupol commented Oct 11, 2021 •
edited
Loading

This PR

  • Enable support of different authentication level through authenticationLevel login parameter
  • Update the tests accordingly
  • Need user feedback before being merged

samsonradu
samsonradu reviewed Oct 11, 2021
View reviewed changes
@drupol drupol force-pushed the feat/support-different-types-of-authentication-level branch 2 times, most recently from b9ccceb to 9f2a331 Compare October 13, 2021 09:46
@drupol drupol force-pushed the feat/support-different-types-of-authentication-level branch from bfe38b4 to 0b35851 Compare October 13, 2021 09:52
samsonradu
samsonradu reviewed Oct 13, 2021
View reviewed changes
Copy link
Contributor

@samsonradu samsonradu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it makes more sense to 'compare' the levels instead of verbosely checking all.

@drupol drupol merged commit 5aec463 into master Oct 13, 2021
@drupol drupol deleted the feat/support-different-types-of-authentication-level branch October 13, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonradu samsonradu samsonradu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drupol @samsonradu