Skip to content

Commit

Permalink
IMP analytic_dimension_id on account.analytic.tag not required
Browse files Browse the repository at this point in the history
  • Loading branch information
angelmoya authored and Saran440 committed Jan 7, 2020
1 parent ce74ab8 commit 14cd2d4
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions analytic_tag_dimension/models/analytic.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,21 +44,21 @@ class AccountAnalyticTag(models.Model):

analytic_dimension_id = fields.Many2one(
comodel_name='account.analytic.dimension',
string='Dimension',
required=True)
string='Dimension')

@api.multi
def get_dimension_values(self):
values = {}
for tag in self:
for tag in self.filtered('analytic_dimension_id'):
code = tag.analytic_dimension_id.code
values.update({
'x_dimension_%s' % code: tag.id})
return values

def _check_analytic_dimension(self):
dimension_ids = self.mapped('analytic_dimension_id').ids
if len(self.ids) != len(dimension_ids):
tags_with_dimension = self.filtered('analytic_dimension_id')
dimensions = tags_with_dimension.mapped('analytic_dimension_id')
if len(tags_with_dimension) != len(dimensions):
raise ValidationError(
_("You can not set two tags from same dimension."))

Expand Down

0 comments on commit 14cd2d4

Please sign in to comment.