Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix use of key and url from env vars #92

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix use of key and url from env vars #92

merged 1 commit into from
Feb 26, 2024

Conversation

malmans2
Copy link
Contributor

Closes #91

@FussyDuck
Copy link

FussyDuck commented Jan 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@malmans2 malmans2 mentioned this pull request Jan 23, 2024
Closed
@veenstrajelmer
Copy link

@malmans2 thanks for this simple but useful fix, it does the trick. I noticed several PR's are awaiting approval so they might not be monitored. @EddyCMWF, you seem the most active recent contributor. Could you confirm whether the open PR's will be taken into consideration? Is there a new cdsapi release scheduled already?

@EddyCMWF EddyCMWF merged commit cf606f9 into ecmwf:master Feb 26, 2024
1 check passed
@malmans2 malmans2 deleted the fix-env-vars branch March 21, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiavati gbiavati gbiavati approved these changes

Assignees
No one assigned
Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdsapi fails to use CDSAPI_KEY environment variable
5 participants
@malmans2 @FussyDuck @veenstrajelmer @gbiavati @EddyCMWF