Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offline logger to match cads-worker #267

Merged
merged 5 commits into from
Feb 5, 2025
Merged

offline logger to match cads-worker #267

merged 5 commits into from
Feb 5, 2025

Conversation

EddyCMWF
Copy link
Contributor

@EddyCMWF EddyCMWF commented Feb 4, 2025

Updating the offline logger used by unit-tests to match that of cads-worker. This means we can add additional kwargs to logger calls without breaking the tests.

@EddyCMWF EddyCMWF requested a review from malmans2 February 4, 2025 11:15
malmans2
malmans2 requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@malmans2 malmans2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add structlog to pyproject.toml

@malmans2 malmans2 self-requested a review February 5, 2025 11:32
@EddyCMWF EddyCMWF merged commit 3116b6b into main Feb 5, 2025
9 checks passed
@EddyCMWF EddyCMWF deleted the feature/logger-to-match-cads-worker branch February 5, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malmans2 malmans2 malmans2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EddyCMWF @malmans2