Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COPDS-2246 #251

Merged
merged 10 commits into from
Dec 18, 2024
Merged

COPDS-2246 #251

merged 10 commits into from
Dec 18, 2024

Conversation

malmans2
Copy link
Member

No description provided.

@malmans2 malmans2 requested a review from EddyCMWF December 18, 2024 10:45
@malmans2 malmans2 marked this pull request as ready for review December 18, 2024 10:45
EddyCMWF
EddyCMWF reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@EddyCMWF EddyCMWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, my only request is to make it fail if location is not provided, i.e. do not use the default location. I know I did this in my demo, but now I'm reviewing it, I see it was not a good idea.

@malmans2
Copy link
Member Author

Looks great, my only request is to make it fail if location is not provided, i.e. do not use the default location. I know I did this in my demo, but now I'm reviewing it, I see it was not a good idea.

Perfect. 100% agree. I think it's good to have a default data_format, everything else is confusing.

@EddyCMWF EddyCMWF merged commit d4e0ffa into main Dec 18, 2024
9 checks passed
@EddyCMWF EddyCMWF deleted the COPDS-2246 branch December 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EddyCMWF EddyCMWF EddyCMWF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malmans2 @EddyCMWF