Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Costing for cads obs including area #234

Merged
merged 7 commits into from
Feb 6, 2025
Merged

Costing for cads obs including area #234

merged 7 commits into from
Feb 6, 2025

Conversation

garciampred
Copy link
Contributor

No description provided.

@garciampred garciampred marked this pull request as draft November 5, 2024 10:56
@EddyCMWF
Copy link
Contributor

Is this still ongoing, or can we close the PR?

@EddyCMWF EddyCMWF closed this Jan 29, 2025
@garciampred
Copy link
Contributor Author

Please reopen, I indent to finish it today or tomorrow.

@garciampred garciampred reopened this Jan 29, 2025
@garciampred garciampred requested a review from EddyCMWF February 4, 2025 11:51
@garciampred garciampred marked this pull request as ready for review February 4, 2025 11:51
EddyCMWF
EddyCMWF approved these changes Feb 6, 2025
View reviewed changes
Copy link
Contributor

@EddyCMWF EddyCMWF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge here, but I like the functionality and may move it to the AbstractCdsAdaptor class in a subsequent PR

@EddyCMWF EddyCMWF merged commit ceb1314 into main Feb 6, 2025
9 checks passed
@EddyCMWF EddyCMWF deleted the costing-for-cads-obs branch February 6, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EddyCMWF EddyCMWF EddyCMWF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garciampred @EddyCMWF