Refactor to create a more maintainable structure #16
Conversation
|
Hi James, we need all the exisiting Names for the adaptors otherwise the current system will stop working. I think your names are the correct ones, so could you add temporary links matching the old "Cds" names to your new ones. |
|
After our long discussion, please remove all the renaming, and just do the restructuring |
cads_adaptors/adaptors/__init__.py
Outdated
| @@ -1,6 +1,9 @@ | |||
| import abc | |||
| from typing import Any, BinaryIO | |||
|
|
|||
| from cads_adaptors import constraints, costing | |||
cads_adaptors/tools/adaptor_tools.py
Outdated
| if not issubclass(adaptor_class, adaptor.AbstractAdaptor): | ||
| raise TypeError(f"{adaptor_class!r} is not subclass of AbstractAdaptor") | ||
| if not issubclass(adaptor_class, AbstractAdaptor): | ||
| raise TypeError(f"{adaptor_class!r} is not subclass of Base") |
There was a problem hiding this comment.
This line needs to be reverted:
| raise TypeError(f"{adaptor_class!r} is not subclass of Base") | |
| raise TypeError(f"{adaptor_class!r} is not subclass of AbstractAdaptor") |
|
I just merged the updates which Ale made to main |
cads_adaptors/adaptors/mars.py
Outdated
| from cads_adaptors.adaptors import cds, Request | ||
|
|
||
|
|
||
| class DirectMarsAdaptor(cds.AbstractCdsAdaptor): |
There was a problem hiding this comment.
| class DirectMarsAdaptor(cds.AbstractCdsAdaptor): | |
| class DirectMarsCdsAdaptor(cds.AbstractCdsAdaptor): |
cads_adaptors/adaptors/mars.py
Outdated
| return open("data.grib") # type: ignore | ||
|
|
||
|
|
||
| class MarsAdaptor(cds.AbstractCdsAdaptor): |
There was a problem hiding this comment.
| class MarsAdaptor(cds.AbstractCdsAdaptor): | |
| class MarsCdsAdaptor(cds.AbstractCdsAdaptor): |
cads_adaptors/adaptors/url.py
Outdated
| from cads_adaptors.adaptors import cds, Request | ||
|
|
||
|
|
||
| class UrlAdaptor(cds.AbstractCdsAdaptor): |
There was a problem hiding this comment.
| class UrlAdaptor(cds.AbstractCdsAdaptor): | |
| class UrlCdsAdaptor(cds.AbstractCdsAdaptor): |
Refactors the organisation of modules for improved readability and maintainability.