Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust ensure_list, with tests #159

Merged
merged 2 commits into from
Jun 13, 2024
Merged

robust ensure_list, with tests #159

merged 2 commits into from
Jun 13, 2024

Conversation

EddyCMWF
Copy link
Contributor

The ensure list was not robust enough, this means that it will convert tuples and sets to lists instead of putting them into a list as the first element

Copy link
Contributor

@ecmwf-cobarzan ecmwf-cobarzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a not in front of isinstance, no?

@EddyCMWF
Copy link
Contributor Author

There should be a not in front of isinstance, no?

No

@ecmwf-cobarzan ecmwf-cobarzan merged commit 3d0c699 into main Jun 13, 2024
9 checks passed
@EddyCMWF EddyCMWF deleted the robust-ensure-list branch June 13, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants