Hotfix/intersect constraints with whole datacubes #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malmans2
reviewed
Jun 10, 2024
malmans2
reviewed
Jun 10, 2024
malmans2
reviewed
Jun 10, 2024
malmans2
approved these changes
Jun 10, 2024
Co-authored-by: Mattia Almansi <m.almansi@bopen.eu>
Co-authored-by: Mattia Almansi <m.almansi@bopen.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first implementation did not account for the trick we do with "complete hypercube" datasets. When the dataset is decribed by a single constriant, i.e. a complete hypercube, the constraints.json is an empty list. Therefore, if the length of constraints is 0, the method should return the request in a list.
Test added