Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle Errors from non http URL sources #60

Closed
EddyCMWF opened this issue Oct 27, 2023 · 1 comment · Fixed by #61
Closed

handle Errors from non http URL sources #60

EddyCMWF opened this issue Oct 27, 2023 · 1 comment · Fixed by #61

Comments

@EddyCMWF
Copy link
Contributor

Current implementation can only handle error messages from http[s] servers. This causes problems for ftp datasets (see #52 ).
The exception handler should be more generic
EddyCMWF added a commit that referenced this issue Oct 27, 2023
@EddyCMWF
#60
a9498aa
EddyCMWF added a commit that referenced this issue Oct 27, 2023
@EddyCMWF
#60
66d8c30
@EddyCMWF
Copy link
Contributor Author

In the end, this issue was fixed along side issue #52

@EddyCMWF EddyCMWF linked a pull request Nov 1, 2023 that will close this issue
60 handle errors from non http url sources #61
Merged
EddyCMWF added a commit that referenced this issue Nov 6, 2023
@EddyCMWF @malmans2
60 handle errors from non http url sources (#61)
7496113 
* generic error hadnling

* generic error hadnling

* #60

* #60

* backup downloader added

* add tests for ftp

* fix urls

* fix test

* cleanup

* wget only

* ftp test added

* multiurl updated to handle ftp properly

* qa

* unit tests

* qa

* removing unused test

* clean up and extra download test

* qa

* Mattia comments addressed

---------

Co-authored-by: Mattia Almansi <m.almansi@bopen.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

60 handle errors from non http url sources ecmwf-projects/cads-adaptors
1 participant
@EddyCMWF