Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deploy request && add deployment input properties #1529

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

baixinsui
Copy link
Contributor

@Alice1319
Copy link
Contributor

LGTM

1 similar comment
@yuanxiaojun987
Copy link

LGTM

swaroopar

This comment was marked as outdated.

@swaroopar
Copy link
Contributor

LGTM. Will be merged once the backend PR is merged.

sorry for the confusion. one small comment added.

@dengyali0125
Copy link

LGTM

2 similar comments
@ruwenqiang123
Copy link

LGTM

@profoundwu
Copy link

LGTM

@baixinsui baixinsui force-pushed the feat/remove_deploy_request branch 2 times, most recently from d8d0db3 to 197fd2c Compare February 25, 2025 02:38
@baixinsui baixinsui force-pushed the feat/remove_deploy_request branch from 197fd2c to 4019cfb Compare February 25, 2025 02:46
@baixinsui baixinsui requested a review from swaroopar February 25, 2025 02:52
Copy link
Contributor

@swaroopar swaroopar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swaroopar swaroopar merged commit 0545cb6 into eclipse-xpanse:main Feb 25, 2025
4 checks passed
@qigaoneng
Copy link

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove redundant columns from SERVICE_DEPLOYMENT
8 participants