move deployment information from basic information block. #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
swaroopar
requested changes
Oct 11, 2024
src/components/content/catalog/services/details/ServiceDetail.tsx
Outdated
Show resolved
Hide resolved
|
LGTM |
Alice1319
force-pushed
the
feature/move-deployment-information
branch
from
d793231 to
1be91fe
Compare
swaroopar
requested changes
Oct 11, 2024
src/components/content/deploymentVariables/DeploymentVariables.tsx
Outdated
Show resolved
Hide resolved
src/components/content/deploymentVariables/DeploymentVariables.tsx
Outdated
Show resolved
Hide resolved
Alice1319
force-pushed
the
feature/move-deployment-information
branch
from
1be91fe to
158ddb3
Compare
|
make deployment variables' description rows keep same height. |
|
boolean type value must be empty if nothing is received from backend: fixed. |
Alice1319
force-pushed
the
feature/move-deployment-information
branch
from
158ddb3 to
bcf30fa
Compare
swaroopar
requested changes
Oct 14, 2024
src/components/content/deploymentVariables/DeploymentVariables.tsx
Outdated
Show resolved
Hide resolved
src/components/content/deploymentVariables/DeploymentVariables.tsx
Outdated
Show resolved
Hide resolved
| return ( | ||
| <Popover | ||
| content={<pre className={oclDisplayStyles.oclDeploymentScript}>{yamlDocument.toString()}</pre>} | ||
| title={'Deployment'} | ||
| title={'Service Availability Configs'} |
There was a problem hiding this comment.
Service Availability Config
Alice1319
force-pushed
the
feature/move-deployment-information
branch
from
bcf30fa to
cca4a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes eclipse-xpanse/xpanse#1944
for isv:
register panel:
catalog:
catalog update:
for csp:
review:
details:
registered service:
