Credentials add field 'site' #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baixinsui
force-pushed
the
feat/credential_set_site
branch
from
c6ef7b8 to
66db419
Compare
swaroopar
reviewed
Sep 3, 2024
There was a problem hiding this comment.
@baixinsui Looks good. will merge once the main PR is merged.
baixinsui
force-pushed
the
feat/credential_set_site
branch
from
66db419 to
27cc569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed eclipse-xpanse/xpanse#1849
Based on eclipse-xpanse/xpanse#1915