Fix #203 : assemble-maven-repository should include PGP signatures in the P2 site #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…signatures in the P2 site Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
test Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
|
@mickaelistria any comments on this? This is now complete from my point of view and I would like to squash/merge it if the build succeeds to have this for the jetty-story so we get PGP signatures there as well. |
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
|
I won't review into details as the work is isolated enough, not intrustive on the core parts and I don't plan to use this mojo (as mentioned earlier, this is IMO a step we don't need from Platform POV). So I trust you judgement and feel free to merge at your own convenience. |
|
Alright, I'll need to fix the test then its ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for maven signatures in the
assemble-maven-repository