Remove colons after empty strings in diff labels #9786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Colin Grant colin.grant@ericsson.com
What it does
In the screenshots for #9765, it is clear that diff widgets can wind up with rather odd initial
:
characters. This is due to faulty logic in the label provider forDiffUri
s, which doesn't check whether a.displayName
is available before creating certain prefixes that use it.How to test
:
character unless that colon is preceded by actual text.Review checklist
Reminder for reviewers