Don't re-open hidden tree-view after reload #9539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvsan09
force-pushed
the
asl/tree-view-hidden-after-reload
branch
2 times, most recently
from
86a9556 to
7a84fe4
Compare
vince-fugnitto
added
plug-in system
vince-fugnitto
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
The changes look good to me 👍
I confirmed the functionality through the following use-cases:
-
rm -rf ~/.theiaand performedreset workbench layoutfor a clean state - 'npm scripts' is visible by default in a new workspace with a
package.jsonpresent - if 'npm scripts' is explicitly hidden, the view does not re-open when reloading the application
- if 'npm scripts' is explicitly opened, the view re-opens when reloading the application (even if no
package.jsonexists)
packages/plugin-ext/src/main/browser/view/plugin-view-widget.ts
Outdated
Show resolved
Hide resolved
The PluginViewWidget has a property to suppress visibility updates from a `when` clause in the case a user specifically requests to hide it. However when the browser got reloaded, the flag was reset to default and did not keep the hide request from the user. This change preserves the flag mentioned above in the PluginViewWidget state, this state is preserved and then available for use in `restoreState` where the flag is now updated to the state before the browser reloads. Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com>
alvsan09
force-pushed
the
asl/tree-view-hidden-after-reload
branch
from
7a84fe4 to
23f907b
Compare
vince-fugnitto
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
I verified the changes and they work well for me, and the code looks good to me as well 👍
I confirmed that #7037 is fixed for a given workspace, the tree-view is not re-added when a user explicitly hides the view.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PluginViewWidget has a property to suppress visibility updates
from a
whenclause in the case a user specifically requests to hideit. However when the browser got reloaded, the flag was reset to
default and did not keep the hide request from the user.
This change preserves the flag mentioned above in the PluginViewWidget
state, this state is preserved and then available for use in
restoreStatewhere the flag is now updated to the state before thebrowser reloads.
Fixes: #7037
Signed-off-by: Alvaro Sanchez-Leon alvaro.sanchez-leon@ericsson.com
What it does
This change preserves the suppress updates flag mentioned above in the PluginViewWidget
state, and then restores it at reload.
How to test
Explorerand gets activated by awhenclause statement e.g vscode example, specifically the 'JSON OUTLINE VIEW', you can also reproduce the problem via the NPM extension.when clause) when opening new work spaces.reset workbench layout.Review checklist
Reminder for reviewers