Fix breakpoint expression resizing #9527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenneth-marut-work
force-pushed
the
breakpoint-input-resize
branch
from
6afb8f3 to
c486e16
Compare
vince-fugnitto
added
debug
kenneth-marut-work
force-pushed
the
breakpoint-input-resize
branch
from
a1606d2 to
e31d44e
Compare
colin-grant-work
approved these changes
Jun 4, 2021
Signed-off-by: Kenneth Marut <kenneth.marut@ericsson.com>
kenneth-marut-work
force-pushed
the
breakpoint-input-resize
branch
from
e31d44e to
f206df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #9526 by adding a resize handler to the debug-breakpoint-widget's input editor. It also adds a resize emitter on the MonacoEditor so that resize events from a parent Widget can be forwarded when necessary.
How to test
Follow the steps outlined in #9526, and observe that the expression input field does resize when the the window is maximized
Review checklist
Reminder for reviewers