terminal: remove process.env from browser #9452
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
process.env is not available when in a browser environment. Webpack most
likely included a shim for it.
How to test
We should get the same default values on both master and this PR for the following preferences, and it should be independent from your
SHELL
environment variable.terminal.integrated.shell.windows
defaults toC:\\Windows\\System32\\cmd.exe
terminal.integrated.shell.osx
defaults to/bin/bash
terminal.integrated.shell.linux
defaults to/bin/bash
Review checklist
Reminder for reviewers