Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal: remove process.env from browser #9452

Merged
merged 1 commit into from
May 10, 2021

Conversation

paul-marechal
Copy link
Member

process.env is not available when in a browser environment. Webpack most
likely included a shim for it.

How to test

We should get the same default values on both master and this PR for the following preferences, and it should be independent from your SHELL environment variable.

  • terminal.integrated.shell.windows defaults to C:\\Windows\\System32\\cmd.exe
  • terminal.integrated.shell.osx defaults to /bin/bash
  • terminal.integrated.shell.linux defaults to /bin/bash

Review checklist

Reminder for reviewers

process.env is not available when in a browser environment. Webpack most
likely included a shim for it.
@paul-marechal paul-marechal added the terminal issues related to the terminal label May 7, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paul-marechal paul-marechal merged commit b4b99ce into master May 10, 2021
@github-actions github-actions bot added this to the 1.14.0 milestone May 10, 2021
@vince-fugnitto vince-fugnitto deleted the mp/browser-process-env branch May 10, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal issues related to the terminal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants