Add UIKind API #8038
Merged
Add UIKind API #8038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tsmaeder first commit is unrelated? Second commit looks simple and clean but some formatting is broken. |
|
@akosyakov ah crap! I didn't branch off master. The first commit is from #7996 (which could use some discussion of the approach, as well ;-)) |
Signed-off-by: Thomas Mäder <tmader@redhat.com>
|
I tested that we get the correct value with a command ("Show UI kind") in my test test extension. |
|
I removed the extra commit and fixed the formatting (some tabs instead of spaces) |
akosyakov
approved these changes
Jun 18, 2020
|
------------------ 原始邮件 ------------------
发件人: "Thomas Mäder"<notifications@github.com>;
发送时间: 2020年6月18日(星期四) 下午5:35
收件人: "eclipse-theia/theia"<theia@noreply.github.com>;
抄送: "Subscribed"<subscribed@noreply.github.com>;
主题: Re: [eclipse-theia/theia] Add UIKind API (#8038)
Merged #8038 into master.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
right
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds the vsode.env.UIKind API in order to enable VS Code extensions, for example ti fix:
Java Test Runner extension doesn't activate and icons are not loaded #8007
The idea is that electron => UIKind.Desktop and everything is UIKind.Web.
How to test
The tests I ran are that the extensions mentioned in the linked PR are coming up. @akosyakov are there any compatility tests I could run for this?
Review checklist
Reminder for reviewers