Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix incorrectly generated api docs #7288

Merged
merged 1 commit into from
Mar 12, 2020
Merged

docs: fix incorrectly generated api docs #7288

merged 1 commit into from
Mar 12, 2020

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #7287

The api-samples was incorrectly included in the generated docs since it had a .tsx file included. Due to the typedoc.json exclude rule not handling the case it was displayed. The exclude rule was updated to be more generic and not publish any documentation for the directories:

  • dev-packages
  • examples
  • typings

How to test

  1. from the root of the repo, run the command:
    yarn run docs
  2. once completed, observe the result by openinggh-pages/docs/next/index.html and verify if the bug has been successfully fixed

Review checklist

Reminder for reviewers

Fixes #7287

The `api-samples` was incorrectly included in the generated docs since it
had a `.tsx` file included. Due to the `typedoc.json` exclude rule not
handling the case it was displayed. The `exclude` rule was updated to be
more generic and not publish any documentation for the directories:
- `dev-packages`
- `examples`
- `typings`

Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto vince-fugnitto added bug bugs found in the application documentation issues related to documentation labels Mar 6, 2020
@vince-fugnitto vince-fugnitto self-assigned this Mar 6, 2020
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't see a reason to publish anything from these folders either.

@vince-fugnitto vince-fugnitto merged commit 05d2eed into master Mar 12, 2020
@vince-fugnitto vince-fugnitto deleted the vf/GH-7287 branch March 12, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: incorrect generated doc for 'sample-uncloseable-view'
2 participants