preview: allow rendering of '.markdown' files #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7228 This commit adds extra handling to be able to render `.markdown` files similarly to `.md`. With this change, users will be able to render both `.md` and `.markdown` files using the `@theia/preview` extension. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
preview
Thank you! Merging since it is relatively low risk and is a nice feature (also for Gitpod) 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com
What it does
Fixes #7228
This commit adds extra handling to be able to render
.markdownfiles similarly to.md. With this change, users will be able to render both.mdand.markdownfiles using the@theia/previewextension.How to test
Test cases were added to validate the
canHandlefunction of theMarkdownPreviewHandler..mdfile (previewing should be available).markdownfile (previewing should be available)Review checklist
Reminder for reviewers