Collapse panel on toggle view #6963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the tests need to be updated as well since the |
Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
spoenemann
force-pushed
the
keep_views_open
branch
from
c613380 to
72f7c15
Compare
akosyakov
reviewed
Jan 27, 2020
akosyakov
reviewed
Jan 27, 2020
- Created a utility function `animationFrame` along with a test to conveniently await one (or more) animation frame. - Fixed a bug in ViewContainerPart where `onBeforeHide` / `onAfterHide` were not propagated to the wrapped widget unless the part was collapsed. Signed-off-by: Miro Spönemann <miro.spoenemann@typefox.io>
|
@akosyakov there was a problem in ViewContainerPart: https://github.com/eclipse-theia/theia/pull/6963/files#diff-67d5dd89ba01138b8b836376084d0985 |
akosyakov
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Even if I once implemented this behavior myself (#1028), I often find it confusing that the command to toggle a view closes it if it's already visible. And I'm not the only one:
#1727 (comment)
arduino/arduino-pro-ide#188
A side effect of this is that if there are views in the sidebar that have not specified a
rank, closing and reopening a view can lead to a different order of icons.I propose to slightly change this behavior. With this PR, the toggle command collapses the containing panel when the view is visible. The result is similar as before: the view is no longer visible. The difference is that the view icon is still there. If you really want to close the view, you can do that with right-click on its icon > Close.
Special rules for the main and bottom panel:
How to test
Use the View menu entries or the respective keybindings to toggle some views.
Review checklist
Reminder for reviewers