Fix CI build

[olexii4]

Signed-off-by: Oleksii Orel oorel@redhat.com

What it does

Fix CI build.

How to test

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[olexii4]

I can't reproduce it locally. So, I am going to test it with CI.

[marcdumais-work]

Hi @olexii4 . FYI the repo was just moved to the eclipse-theia organization and CI is not completely configured yet. so issues are expected.

[kittaakos]

I can't reproduce it locally

I could not reproduce it locally either.

FYI the repo was just moved to the eclipse-theia organization and CI is not completely configured yet

Perfect timing 😄. Shall we revert the PR?

[kittaakos]

I can't reproduce it locally.

Nice that you found the fix, but can you explain why it worked locally and not from the CIs?

[olexii4]

@kittaakos I cannot tell exactly(ideas only). I just fixed an error from the CI log.

[kittaakos]

I can't reproduce it locally

I could not reproduce it locally either.

It was a test failure. We do not run the tests :/

I cannot tell exactly(ideas only).

I did not know it either.

When we load the connection-status-service.spec module with mocha the following modules will be required and loaded: connection-status-service > frontend-application > shell/shell-layout-restorer > theming. The required object exists. It cannot be an incorrect CSS file path or config issue in mocha.

require('../../src/browser/style/materialcolors.css')
Object {}
[[StableObjectId]]:8
__proto__:Object {constructor: , __defineGetter__: , __defineSetter__: , …}
__defineGetter__:function __defineGetter__() { … }
__defineSetter__:function __defineSetter__() { … }
__lookupGetter__:function __lookupGetter__() { … }
__lookupSetter__:function __lookupSetter__() { … }
[[StableObjectId]]:9
constructor:function Object() { … }
hasOwnProperty:function hasOwnProperty() { … }
isPrototypeOf:function isPrototypeOf() { … }
propertyIsEnumerable:function propertyIsEnumerable() { … }
toLocaleString:function toLocaleString() { … }
toString:function toString() { … }
valueOf:function valueOf() { … }
__proto__:null

(from debug console ☝️)

However, the style-loader does not work in mocha tests.

[vince-fugnitto]

I can't reproduce it locally. So, I am going to test it with CI.

@olexii4 I can confirm that it fails on master when executing the tests:

$ npx run test @theia/core

...

/Users/vincentfugnitto/workspace/theia/packages/core/lib/browser/theming.js:43
require('../../src/browser/style/materialcolors.css').use();
                                                      ^

TypeError: require(...).use is not a function
    at Object.<anonymous> (/Users/vincentfugnitto/workspace/theia/packages/core/lib/browser/theming.js:43:55)
    at Module._compile (internal/modules/cjs/loader.js:701:30)
    at Module.replacementCompile (/Users/vincentfugnitto/workspace/theia/node_modules/nyc/node_modules/append-transform/index.js:58:13)
    at module.exports (/Users/vincentfugnitto/workspace/theia/node_modules/nyc/node_modules/default-require-extensions/js.js:8:9)
    at Object.<anonymous> (/Users/vincentfugnitto/workspace/theia/node_modules/nyc/node_modules/append-transform/index.js:62:4)
    at Module.load (internal/modules/cjs/loader.js:600:32)
    at tryModuleLoad (internal/modules/cjs/loader.js:539:12)
    at Function.Module._load (internal/modules/cjs/loader.js:531:3)
    at Module.require (internal/modules/cjs/loader.js:637:17)
    at Module.require (/Users/vincentfugnitto/workspace/theia/node_modules/monaco-languageclient/lib/register-vscode.js:12:28)
    at require (internal/modules/cjs/helpers.js:22:18)

...

On a separate note, can you update the PR message and description to accurately describe the fix?
Looking back at the PR in history, "Fix CI build" won't say much as to what the problem was (in an effort to not repeat the problem again).

[akosyakov]

let's merge as soon as travis is green