Fix regression preventing command palette from opening #5888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
added
bug
vince-fugnitto
requested review from
azatsarynnyy,
RomanNikitenko and
akosyakov
azatsarynnyy
approved these changes
Aug 8, 2019
akosyakov
reviewed
Aug 8, 2019
RomanNikitenko
approved these changes
Aug 8, 2019
vince-fugnitto
force-pushed
the
vf/GH-5887
branch
from
64657b3 to
61fa7f6
Compare
paul-marechal
force-pushed
the
vf/GH-5887
branch
2 times, most recently
from
2375d8e to
58f7b1c
Compare
|
I fixed the other places where something like Sorry for changing an already approved change... |
Fixes #5887 - fixes issue where the command palette can not be opened when there is no workspace set. (caused by changes made in the 'cpp-build-configuration#getActiveConfig') - if no workspace is present, return `undefined` instead of attempting to get the activeConfig for the workspace root. - fix frozen object access by working on a deep-cloned copy. Signed-off-by: Vincent Fugnitto <vincent.fugnitto@ericsson.com>
paul-marechal
force-pushed
the
vf/GH-5887
branch
from
58f7b1c to
3332f9b
Compare
|
Fixed a last issue where code would throw -but not stop any process/logic- on each workspace opening. @akosyakov @vince-fugnitto @RomanNikitenko @azatsarynnyy sorry for the trouble. |
azatsarynnyy
approved these changes
Aug 8, 2019
akosyakov
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #5887
there is no workspace set. (caused by changes made in the 'cpp-build-configuration#getActiveConfig')
undefinedinstead of attempting to get the activeConfigfor the workspace root.
How to test
Review checklist
Reminder for reviewers
Signed-off-by: Vincent Fugnitto vincent.fugnitto@ericsson.com