Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added workspace symbols plugin api #3513

Merged
merged 1 commit into from
Dec 25, 2018

Conversation

JPinkney
Copy link
Contributor

Adds workspace symbols plugin api and modified types to be consistent with VSCode.

Related to: #3353 and #3387

@JPinkney JPinkney force-pushed the workspace-symbols-plugin-api branch 2 times, most recently from ccc5da5 to 4355bcf Compare November 15, 2018 16:58
@benoitf benoitf requested a review from akosyakov November 15, 2018 22:15
@JPinkney JPinkney force-pushed the workspace-symbols-plugin-api branch from 4102710 to 1a19211 Compare November 17, 2018 15:16
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: jpinkney <josh.pinkney@mail.utoronto.ca>
@JPinkney JPinkney force-pushed the workspace-symbols-plugin-api branch from 476f2e0 to f33bd46 Compare December 23, 2018 04:01
@tolusha tolusha merged commit 0a00d78 into eclipse-theia:master Dec 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants