webview: fix host.js logic #10336
Merged
webview: fix host.js logic #10336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic previously stopped the handler after running `this.postMessage` but I forgot to follow this when modifying this code in another PR. Fix the logic by respecting what was previously done.
vince-fugnitto
approved these changes
Oct 27, 2021
mcgordonite
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Nov 1, 2021
The logic previously stopped the handler after running `this.postMessage` but I forgot to follow this when modifying this code in another PR. Fix the logic by respecting what was previously done.
westbury
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Nov 3, 2021
The logic previously stopped the handler after running `this.postMessage` but I forgot to follow this when modifying this code in another PR. Fix the logic by respecting what was previously done.
westbury
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Nov 3, 2021
The logic previously stopped the handler after running `this.postMessage` but I forgot to follow this when modifying this code in another PR. Fix the logic by respecting what was previously done.
westbury
pushed a commit
to ARMmbed/theia
that referenced
this pull request
Nov 3, 2021
The logic previously stopped the handler after running `this.postMessage` but I forgot to follow this when modifying this code in another PR. Fix the logic by respecting what was previously done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic previously stopped the handler after running
this.postMessagebut I forgot to follow this when modifying this codein another PR.
Fix the logic by respecting what was previously done.
Fix #10331.
cc @StanZGenchev.
How to test
custom-editor-samplefrom the official https://github.com/microsoft/vscode-extension-samples and run it.example.cscratchfile inexampleFilesin thecustom-editor-samplefolder.Review checklist
Reminder for reviewers