monaco: fix styling in monaco suggest-overlay #10241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit fixes the styling for focused elements in the monaco suggestion overlay: - applies the foreground color properly for focused elements - applies the background color properly for focused elements - styles the `suggest-icon` properly for focused elements Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
vince-fugnitto
added
theming
|
@Delwing would you like to give it a try :) |
|
That was lightning fast :) Checking :) |
|
Awesome. Fixes also other bundled themes. 👍🏻 💯 |
msujew
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10239
The commit fixes the styling for focused elements in the monaco suggestion overlay:
suggest-iconproperly for focused elementsLight:
Dark:
Monokai:
How to test
suggestionsare correctly styledReview checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com