Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m2e-pde integration for pom dependencies #242

Closed
vogella opened this issue Jun 17, 2021 · 6 comments
Closed

m2e-pde integration for pom dependencies #242

vogella opened this issue Jun 17, 2021 · 6 comments
Labels
pde-integration M2Eclipse PDE Integration question Further information is requested
Milestone

Comments

@vogella
Copy link
Contributor

vogella commented Jun 17, 2021

AFAIK the current m2e-pde integration does not allow to use Maven dependencies if they are "only" poms. For example:

<dependency>
  <groupId>com.itextpdf</groupId>
  <artifactId>itext-parent</artifactId>
  <version>1.0.0</version>
  <type>pom</type>
</dependency>

Would be cool if m2e-pde could also support these and get the defind dependencies as it does for the dependencies of Java libraries.

@laeubi laeubi added the pde-integration M2Eclipse PDE Integration label Jun 17, 2021
@laeubi
Copy link
Member

laeubi commented Jun 17, 2021

Yep that is an open issue :-)

Its on my todo list but at the moment not high-priority, if there are customer demands feel free to contact me and offer a funding for such a feature.

laeubi added a commit to laeubi/m2e-core that referenced this issue Jun 21, 2021
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi added a commit to laeubi/m2e-core that referenced this issue Jun 21, 2021
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Member

laeubi commented Jun 21, 2021

@vogella I have created some adjustment but your example seems to be a bad use-case (except for the fact that it should not generate an error) as it has no compile or other dependencies. So adding this to the target currently could not have any effect.

@laeubi laeubi added the question Further information is requested label Jun 21, 2021
@vogella
Copy link
Contributor Author

vogella commented Jun 21, 2021

Looking at the itext pom dependency again, I see that it has no dependency. Sorry for this bad example.

@laeubi
Copy link
Member

laeubi commented Jun 21, 2021

No problem if you find a more suitable one I could use for testing let me know!

laeubi added a commit to laeubi/m2e-core that referenced this issue Jul 18, 2021
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
laeubi added a commit to laeubi/m2e-core that referenced this issue Jul 18, 2021
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Member

laeubi commented Oct 8, 2021

https://mvnrepository.com/artifact/com.sun.xml.ws/jaxws-ri/3.0.2 might be a better example here ...

@laeubi laeubi added this to the 1.18.2 milestone Oct 12, 2021
@laeubi
Copy link
Member

laeubi commented Oct 12, 2021

I have checked this with the jaxws-ri dependency mentioned above and it works like expected:

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pde-integration M2Eclipse PDE Integration question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants