Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for langium-cli mode #1077

Merged
merged 3 commits into from
Jun 13, 2023
Merged

Add support for langium-cli mode #1077

merged 3 commits into from
Jun 13, 2023

Conversation

msujew
Copy link
Member

@msujew msujew commented Jun 7, 2023

To improve bundle size when building a Langium based language server/parser, generating more succinct code is beneficial. This change adds a --mode argument for generating a compressed version of the grammar json.

@msujew msujew added the cli CLI related issue label Jun 7, 2023
@msujew msujew marked this pull request as ready for review June 7, 2023 13:21
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good feature!

@spoenemann spoenemann added this to the v2.0.0 milestone Jun 8, 2023
@Lotes
Copy link
Contributor

Lotes commented Jun 9, 2023

The term mode is very broad. I would associate this with a deployment environment or bundling behavior.

Mode is like type or kind. Very unspecific and confusing. You can get some inspiration from other build tools I hope.

@spoenemann
Copy link
Contributor

@Lotes here's the inspiration: https://webpack.js.org/configuration/mode/

@msujew msujew merged commit 5f2a048 into main Jun 13, 2023
@msujew msujew deleted the msujew/cli-mode branch June 13, 2023 17:21
spoenemann pushed a commit that referenced this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli CLI related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants