Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompilationUnit does not contains modifier for the ImplicitTypeDeclaration #3730

Open
wants to merge 1 commit into
base: BETA_JAVA24
Choose a base branch
from

Conversation

subyssurendran666
Copy link
Contributor

@subyssurendran666 subyssurendran666 commented Feb 12, 2025

What it does

All the necessary informations has beed added to the parent ticket.
This PR closes #3696

How to test

Author checklist

Copy link
Contributor

@mpalat mpalat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@subyssurendran666 please take a look at Record also - here final is implicit. Let's check how its implemented there

@subyssurendran666
Copy link
Contributor Author

@subyssurendran666 please take a look at Record also - here final is implicit. Let's check how its implemented there

I have analysed the Record and which is Implicitly "public final", ie record Eclipse(String name, int age) {} which is equivalent to public final record Eclipse(String name, int age) {}.

There is no modifiers property attached to the RecordDeclaration if it is set implicitly. Therefore, the same approach can be followed here. We can modify the Javadoc of the ImplicitTypeDeclaration node.

@mpalat
Copy link
Contributor

mpalat commented Feb 18, 2025

@subyssurendran666 please take a look at Record also - here final is implicit. Let's check how its implemented there

I have analysed the Record and which is Implicitly "public final", ie record Eclipse(String name, int age) {} which is equivalent to public final record Eclipse(String name, int age) {}.

There is no modifiers property attached to the RecordDeclaration if it is set implicitly. Therefore, the same approach can be followed here. We can modify the Javadoc of the ImplicitTypeDeclaration node.

Great - I agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants