Avoid duplicate calls in ReferenceBinding::superInterfaces #3601 #3710
Conversation
…t#3601 - Make the method final - Add new recursive method ReferenceBinding.superInterfacesRecursive that takes an IndentityHashMap to keep the visited types Fixes eclipse-jdt#3601
|
|
||
| protected ReferenceBinding[] superInterfacesRecursive(Map<ReferenceBinding, Object> visited) { | ||
| if (visited.put(this, this) != null) { // do not evaluate the same type twice | ||
| return this.superInterfaces; |
There was a problem hiding this comment.
Hi @jukzi,
this i moved this PR here but it is the same as #3622.
Regarding your question https://github.com/eclipse-jdt/eclipse.jdt.core/pull/3622/files/67baa79f72287ae12a64123dc7b2e184cada4754#r1932431660:
As far as i know, it does not return here. I checked this while building smaller, non-Eclipse projects so there is a chance that this code was not called with the correct conditions to return here.
Regarding the junit testcase, do you mean a testcase that executes duplicted calls?
There was a problem hiding this comment.
Correction: It can return here and im trying to figure out under which conditions it does
There was a problem hiding this comment.
Regarding the junit testcase, do you mean a testcase that executes duplicted calls?
a reproducer should visit the same interface/class multiple times
Make the method final
Add new recursive method ReferenceBinding.superInterfacesRecursive that takes an IndentityHashMap to keep the visited types
Fixes #3601
Supersedes #3622