Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompletionTests.testBug343342 makes no sense #3781

Open
datho7561 opened this issue Mar 11, 2025 · 1 comment · May be fixed by #3783
Open

CompletionTests.testBug343342 makes no sense #3781

datho7561 opened this issue Mar 11, 2025 · 1 comment · May be fixed by #3783

Comments

@datho7561
Copy link
Contributor

It tests completion at the | in the following CU. The linked issue is about completion in case, so I expect this is a bug.

package |test;
public class Try {
	void f(int a){
		String xyz = null;
		final String xyzz = null;
		switch (a){
			case xy : break;
		}
	}
}

I think this is what is intended to be tested (completion at the |):

package test;
public class Try {
	void f(int a){
		String xyz = null;
		final String xyzz = null;
		switch (a){
			case xy| : break;
		}
	}
}
@datho7561
Copy link
Contributor Author

datho7561 commented Mar 11, 2025

Hold up, I think I have a modified copy of the file, I'll need to see if the modifications were what introduced the bug.

Nope, this is how the test is in this repo as well: https://github.com/eclipse-jdt/eclipse.jdt.core/blob/master/org.eclipse.jdt.core.tests.model/src/org/eclipse/jdt/core/tests/model/CompletionTests.java#L22227

datho7561 added a commit to datho7561/eclipse.jdt.core that referenced this issue Mar 11, 2025
Fixes eclipse-jdt#3781

Signed-off-by: David Thompson <davthomp@redhat.com>
@datho7561 datho7561 linked a pull request Mar 11, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant