-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional policy scopes #1699
feat: additional policy scopes #1699
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1699 +/- ##
==========================================
- Coverage 67.85% 67.81% -0.04%
==========================================
Files 782 785 +3
Lines 16759 16843 +84
Branches 1064 1068 +4
==========================================
+ Hits 11371 11422 +51
- Misses 4918 4950 +32
- Partials 470 471 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
fdce93a
to
b3bb23f
Compare
What this PR changes/adds
It introduces two new policy scopes. The first one is
contract.cataloging
, which is used during the cataloging phase. The previously existing scopecontract.negotiation
is now used during the negotiation itself and to re-evaluate the policies before a new transfer process is created. The other new scope isprovision.manifest.verify
, which is used to evaluate a generatedResourceManifest
to ensure that it fulfils the given policy.Why it does that
Currently, policy evaluation only takes place during the negotiation phase.
Further notes
Introduces the possibility to pass additional context information to the
PolicyEngine
, which is available to evaluation functions via thePolicyContext
. This is required to pass information about theResourceManifest
to the functions.Linked Issue(s)
Closes #1446
Closes #1331
Checklist
no-changelog
)