[Test] Update 'Factory' E2E test #23336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artaleks9
requested review from
musienko-maxim and
dmytro-ndp
as code owners
dmytro-ndp
reviewed
Feb 10, 2025
| * select creation of a new workspace, if a duplicate workspace is created from the factory or sample list. | ||
| * this option is false by default. | ||
| */ | ||
| SELECT_OF_CREATION_NEW_WORKSPACE: process.env.SELECT_OF_CREATION_NEW_WORKSPACE === 'true', |
There was a problem hiding this comment.
IMHO SELECT_CREATING_NEW_WORKSPACE name should be more relevant in this case
There was a problem hiding this comment.
Also, default value = true is probably conflicting with another constant value SELECT_OPENING_EXISTING_WORKSPACE_INSTEAD_OF_CREATION_NEW=== true
There was a problem hiding this comment.
Both constants SELECT_CREATING_NEW_WORKSPACE and SELECT_OPENING_EXISTING_WORKSPACE_INSTEAD_OF_CREATION_NEW have default value false
dmytro-ndp
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FactoryE2E test to do checking test-cases of factory with gitlab server private/public repo when OAuth token is refreshed.SELECT_OF_CREATION_NEW_WORKSPACEtotests/e2e/constants/BASE_TEST_CONSTANTS.tsScreenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
Run the
Factory.spec.tsas usualPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.