Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add in vscode-builtin-php #648

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Conversation

JPinkney
Copy link
Contributor

@JPinkney JPinkney commented Mar 2, 2020

What does this PR do?

This PR adds in the vscode-builtin-php. I believe the reason we didn't originally add this was because of eclipse-theia/theia#6672 but from playing around with and investigating the Theia code I don't think it's really an issue. Also, cpp and yaml (when you have vscode-yaml activated) both show these errors as well. This builtin is needed otherwise PHP highlighting and language features won't work in any of the PHP stacks.

To test use the PHP symphony devfile and add in:

  - type: chePlugin
    reference: >-
      https://gist.githubusercontent.com/JPinkney/5cad64651e4f609f019be617d2098129/raw/ac7ad2ccc95ae743a57f4e9f285b1f69c287ec4f/meta.yaml

Then open up a PHP file and you should have highlighting, outline, etc working.

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

What issues does this PR fix or reference?

eclipse-che/che#16196
eclipse-che/che#16114

Release Notes

Docs PR

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@azatsarynnyy
Copy link
Member

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Mar 3, 2020
@azatsarynnyy
Copy link
Member

crw-ci-test

@azatsarynnyy
Copy link
Member

[ci-build]

@azatsarynnyy
Copy link
Member

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Mar 3, 2020
@azatsarynnyy
Copy link
Member

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Mar 3, 2020
@rhopp
Copy link
Contributor

rhopp commented Mar 3, 2020

crw-ci-test
(last try ;-P)

Copy link

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rhopp
Copy link
Contributor

rhopp commented Mar 3, 2020

crw-ci-test

@che-bot
Copy link
Contributor

che-bot commented Mar 3, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:648
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:648

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member

crw-ci-test

@eclipse-che eclipse-che deleted a comment from che-bot Mar 4, 2020
@che-bot
Copy link
Contributor

che-bot commented Mar 4, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:648
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:648

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@azatsarynnyy
Copy link
Member

Happy path are failed on Validation of workspace build and run step.
That is a known issue related to https mode.
Since the changes don't touch run/debug application functionality, we're merging the PR.

@azatsarynnyy azatsarynnyy merged commit 8c5f9cd into eclipse-che:master Mar 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants