-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
crw-ci-test |
crw-ci-test |
[ci-build] |
crw-ci-test |
crw-ci-test |
crw-ci-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
crw-ci-test |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
crw-ci-test |
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
Happy path are failed on |
What does this PR do?
This PR adds in the vscode-builtin-php. I believe the reason we didn't originally add this was because of eclipse-theia/theia#6672 but from playing around with and investigating the Theia code I don't think it's really an issue. Also, cpp and yaml (when you have vscode-yaml activated) both show these errors as well. This builtin is needed otherwise PHP highlighting and language features won't work in any of the PHP stacks.
To test use the PHP symphony devfile and add in:
Then open up a PHP file and you should have highlighting, outline, etc working.
Signed-off-by: Josh Pinkney joshpinkney@gmail.com
What issues does this PR fix or reference?
eclipse-che/che#16196
eclipse-che/che#16114
Release Notes
Docs PR