MCT diffusive wave routing #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 25, 2023 17:17
…olves issue with mBE in SplitRouting
…ugfix for mBE and warm start
…on fix) and small fixes to unit tests.
…/ec-jrc/lisflood-code into feature/mct_optim_results_update
Fixing warm start and updating reference results for MCT
doc78
reviewed
Feb 13, 2025
tests/test_inflow.py
Outdated
There was a problem hiding this comment.
I see this test has been removed. Is it replaced by test_dyn_inflow?
doc78
reviewed
Feb 13, 2025
|
|
||
| def run(self, date_start, date_end, dtsec, type): | ||
| # generate inflow (inflow.tss) one pixel upstream of inflow point | ||
| out_path_ref = os.path.join(self.case_dir, 'reference_mct_dyn') |
There was a problem hiding this comment.
I see here and in other unit tests that we are creating output files outside the "out" folder. Is there a reason for that? (I know that sometimes running unit tests in parallel and removing completely the out folder in the teardown method can cause the test to fail: was this the reason? If so I agree we should fix up all teardown methods before fixing the out folder...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of MCT diffusive wave routing.
Tests were added for the MCT implementation. Tests run with only core LISFLOOD components on.
For MCT 'Dynamic' tests, the reference outputs are generated on the fly and tests should still pass after merging. MCT tests using fixed reference outputs (testing results) should pass after merging if there are no changes to the core LISFLOOD components.
MCT tests come in two flavors:'short' tests run on a small catchment (a small sub-catchment of the Po); 'long' tests run on LF_ETRS89_UseCase.