Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

128 channel support with user feedback #254

Merged
merged 34 commits into from
Nov 3, 2023
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
40283ca
Initial changes for 128 channels
firthm01 Apr 3, 2023
5df3fdd
Remove unused 64-channel limited funcs
firthm01 Apr 6, 2023
8d34671
Update test for channel out-of-bounds
firthm01 Apr 6, 2023
bc48869
rn global_config.h daw_channel_count.h
firthm01 Oct 4, 2023
a11a9b5
Funcs to get DAW channel count
firthm01 Oct 4, 2023
9cfcce3
Full bus routing uses api.GetDawChannelCount()
firthm01 Oct 4, 2023
aa10ba2
EAR UniqueValueAssigner should only use currently available channels
firthm01 Oct 5, 2023
546daa4
EarComboBoxEntry::setSelectable and make visible changes
firthm01 Oct 6, 2023
bd62ad9
getEntryById to retrieve EarComboBoxEntry object
firthm01 Oct 6, 2023
0e38b33
getPopup method so parent classes can access entries
firthm01 Oct 6, 2023
3fd8fb6
Impl DAW channel count UI changes in Obj plugin
firthm01 Oct 6, 2023
cee7e33
add*Entry methods return the constructed entry
firthm01 Oct 6, 2023
b43d110
Impl DAW channel count UI changes in HOA plugin
firthm01 Oct 6, 2023
f15d61d
Impl DAW channel count UI changes in DS plugin
firthm01 Oct 6, 2023
2768bc0
Error message for missing AXML/CHNA chunk
firthm01 Oct 10, 2023
4f2dd24
Routing info tooltip on REAPER <v7 (Obj plugin)
firthm01 Oct 11, 2023
d031971
Routing info tooltip on REAPER <v7 (HOA plugin)
firthm01 Oct 11, 2023
4099b4e
Routing info tooltip on REAPER <v7 (DS plugin)
firthm01 Oct 11, 2023
935f83c
Recentre the DS meters
firthm01 Oct 12, 2023
ed555b8
Import classes support receiving warning messages
firthm01 Oct 11, 2023
1623858
Import dialog only closes automatically if no warnings occurred
firthm01 Oct 11, 2023
6fd222d
Handle ImportStatus::COMPLETE state only once
firthm01 Oct 11, 2023
8060c7d
PluginSuites can pass back error messages
firthm01 Oct 12, 2023
8fd1516
Show warnings to user
firthm01 Oct 12, 2023
c3d70d0
Might as well implement warnings about unsupported PFs
firthm01 Oct 12, 2023
b2ec02f
Fix missing include
firthm01 Oct 17, 2023
86e2890
Show ear-plugin-base headers in IDE
firthm01 Nov 2, 2023
2d08f3b
Move common vst-reaper integration code into separate header
firthm01 Nov 2, 2023
c0bd7fc
Move registerPluginLoad code to reaper_integration
firthm01 Nov 2, 2023
f8df265
Move requestInputInstanceId code to reaper_integration
firthm01 Nov 2, 2023
9076ff2
Make MAX_DAW_CHANNELS a constexpr
firthm01 Nov 2, 2023
731d434
Use static_cast over c-sytle
firthm01 Nov 2, 2023
0948108
Common setup code for Routing Info Icon
firthm01 Nov 2, 2023
a7d37bc
Common positioning code for Routing Info Icon
firthm01 Nov 2, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use static_cast over c-sytle
  • Loading branch information
firthm01 committed Nov 2, 2023
commit 731d43447b26366812f766ec7a426e52dc77a071
2 changes: 1 addition & 1 deletion reaper-adm-extension/src/reaper_adm/admvstcontrol.h
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ using namespace admplug;
#define ADM_VST_SAMPLERATEPARAM_NORMLIMIT 192000.0

#define ADM_VST_NUMCHNSPARAM 4
#define ADM_VST_NUMCHNSPARAM_NORMLIMIT float(MAX_DAW_CHANNELS)
#define ADM_VST_NUMCHNSPARAM_NORMLIMIT static_cast<float>(MAX_DAW_CHANNELS)

#define ADM_VST_ADMTYPEDEFINITIONPARAM 5
#define ADM_VST_ADMPACKFORMATPARAM 6