Linux support #222
Linux support #222
Conversation
|
For reference, I've been building with: cmake -B build/ -G Ninja -DEAR_PLUGINS_UNIT_TESTS=OFF -DBUILD_TESTING=OFF -DSMTG_CREATE_PLUGIN_LINK=0 -DCMAKE_BUILD_TYPE=Debug
ninja -C build install |
|
I just tried compilation on my Ubuntu 20.04.
|
Thanks, but yeah, as mentioned on the other thread it will probably require using vcpkg -- ubuntu 20.04 ships protobuf 3.6.1.3, while vcpkg provides 3.18.0. I'll try to put together some instructions for this next week. |
I think that's probably the case - certainly true when I do the same in Windows |
tomjnixon
force-pushed
the
linux_support
branch
4 times, most recently
from
fa94b52 to
e3d9df7
Compare
on linux, this depends on other static initialisers having been ran (specifically the "text" constant in the XML parser), and they may end up running in the wrong order (the main change is in fonts.hpp; the rest is search/replace)
this was checked in the monitoring plugin, but not the scene plugin
this issues warnings about missing plist files, but works according to the VST3 specs the .vst3 should actually be a directory structure containing the library, but this works for now
this matches what the official JUCE cmake scripts do without this, all plugins end up sharing one message thread, which might be fine one some platforms, but on linux the VST wrapper assumes that there is a message thread for each plugin, and this ultimately causes callOnMessageThread callbacks to not get called unless the plugin window is open (specifically, it does something like using the run state of the messaging thread to decide whether to register with the VST event loop -- it's quite complicated and unclear) note that plugins are dlopened with RTLD_LOCAL, which you might think would stop this kind of sharing, but no -- the message thread is created with SharedResourcePointer, which is a template class and so the static variable lives in an inline function, which gets marked as "unique global", which still get merged it might be sensible to add this to the reaper_adm plugin and other libraries we use -- they mostly use static initialisation for caching so aren't affected by this, but it could cause issues when mixing plugins of different versions for debugging, for example
the user VST path does not end with "/VST3", so merge that into the prefix perhaps it would be better to make the full install dir somewhere centrally so that the VST3 part could be left out of the prefix on other platforms?
for some reason the POSITION_INDEPENDENT_CODE target property doesn't get propagated to the tests, which then fail to link really everything in this project should be built with PIC, and this is an easier way to get that
addPoint can cause the underlying vector to be reallocated, which invalidates references to it
abs can refer to the C integer version, causing inaccuracy testing on Linux picked this up, so the float version was probably getting used production builds
- use VCPKG_DEFAULT_BINARY_CACHE instead of VCPKG_BINARY_SOURCES -- this should have the same effect, but is simpler - use the same timestamp mechanism as ccache for saving the cache this means that the cache will always be saved, and so will keep up to date even if a change on the runner invalidates it - don't invalidate the cache when something changes in vcpkg, as it can work that out itself - add a script to prune the vcpkg cache to a set size (500MB) -- this is required when using timestamps as otherwise the cache will keep growing
tomjnixon
force-pushed
the
linux_support
branch
from
78f5166 to
9e29e6e
Compare
tomjnixon
force-pushed
the
linux_support
branch
from
9e29e6e to
32eaaab
Compare
|
Merged in to v1.0 PR |
Build and test cross-platform Installer Support for ADM "Importance" parameter Fix bug in render dialog when using language packs (Closes #215) Include Experimental Linux build (Closes #222) Silence unused monitoring output channels (prevents pass-through of object audio) (Closes #224) Fix alignment of monitoring meters (Closes #206) Fix blank audioProgrammeLanguage on export (Closes #213) Export uses 2076-2 structures (omitting AudioTrackFormat and AudioStreamFormat) Build fixes; Build failing on Xcode 14 (Closes #220), Build fails on MacOS 12 due to vcpkg unable to find python (Closes #221) Include additional project templates Fix unintended downmix issue (Closes #228) Fix plugin crash on other DAWs (Closes #232) Support plugin renaming (Closes #240) Fix parameters not updating in response to other parameter changes after JUCE upgrade Fix blank Scene when importing ADM with no high-level metadata (Closes #242) Various optimisations (reducing lock lengths, only running metering calcs when needed) Bus-width compatibility fixes. Fix for some render dialog controls re-enabling. Fix for updated text in render dialog in recent versions of REAPER.
This should be ready to merge; there are a couple of things still to look at, but these can be turned into issues as it still works:
crash in nng expire thread while scanning (probably just takes too long in debug)
warnings from cmake install phase, and .vst3 files should be directories containing shared objects, rather than shared objects
commits prefixed with
linux:are only required for linux supportcommits prefixed with
ci:are improvements to the github actions script (kept here to avoid merge pains)other commits are general fixes or upgrades that i made along the way
Notes: