Binaural Monitoring fixes #183
Conversation
ear-production-suite-plugins/lib/src/binaural_monitoring_backend.cpp
Outdated
Show resolved
Hide resolved
ear-production-suite-plugins/lib/src/binaural_monitoring_backend.cpp
Outdated
Show resolved
Hide resolved
| std::shared_ptr<ToggleButton> button) { | ||
| button->addListener(this); | ||
| oscInvertYawButton_ = button; | ||
| setOscInvertYaw(cachedOscInvertYaw_); |
There was a problem hiding this comment.
Nitpicking again, could std::move all the passed buttons into their member vars to avoid copying the shared_ptr twice (once in pass-by-value, once in the copy-assign), e.g.
oscInvertPitchButton_ = std::move(button);
In practice probably doesn't matter as these methods won't get called often.
There was a problem hiding this comment.
This is a C+P of the existing pattern in other plugins so we should change this everywhere if we're going to tackle it here.
| } else if (parameterIndex == (int)ParameterId::OSC_INVERT_YAW) { | ||
| updater_.callOnMessageThread([this, parameterIndex, newValue]() { | ||
| notifyParameterChanged(ParameterId::OSC_INVERT_YAW, | ||
| p_->getOscInvertYaw()->get()); | ||
| setOscInvertYaw(p_->getOscInvertYaw()->get()); | ||
| }); |
There was a problem hiding this comment.
I mentioned I'd noticed an odd pattern when I was going through these classes - this is it.
Not sure why we are capturing newValue, then retrieving it from the parameter rather then just using the value? Looks like a common pattern pretty much everywhere.
I guess we should either use newValue rather than doing p_->xxx->get(), or remove it from the lambda captures and have it as an unused/unnamed parameter in the parameterValueChanged function?
There was a problem hiding this comment.
Yeah, good point. I wonder if it's because it's on a different thread and it's better to just get the "current" value than the one passed in?
There was a problem hiding this comment.
This is another C+P of an existing pattern - should be tidied everywhere
...ction-suite-plugins/plugins/binaural_monitoring/src/binaural_monitoring_plugin_processor.cpp
Outdated
Show resolved
Hide resolved
...ction-suite-plugins/plugins/binaural_monitoring/src/binaural_monitoring_plugin_processor.cpp
Show resolved
Hide resolved
ear-production-suite-plugins/plugins/binaural_monitoring/src/orientation_osc.cpp
Outdated
Show resolved
Hide resolved
saves to project data
~/Library/Audio/Plug-Ins/VST3/ear-production-suite/EAR Binaural Monitoring.settings
0.6.0 didn't have the all_available_items field, so bin mon didn't reserve any channels in BEAR and it crashed when we tried to pump metadata in to BEAR. Fixes #180
JUCE patch fixed return value of osc.connect
firthm01
force-pushed
the
bin-mon-fixes
branch
from
bbddc4b to
cf8e699
Compare
firthm01
force-pushed
the
bin-mon-fixes
branch
from
80a63c6 to
01068f1
Compare
Inversion controls - closes #177
Use OSC config file rather than project data - closes #182
Patch JUCE to detect occupied port on Windows - closes #169
Gracefully handle plug-ins mismatch - closes #180